perl Script trouble shoot (copy files issue)

knockout_artist · 10-07-2008, 11:09 AM

Hi,

I wrote/copy this script to read file from one directory and copy them to an other.
But in only do partial job.

I ran It as root. it does copy few file then breaks.

Code:



use Cwd;
use File::Copy;

sub mnt{
system("mount server:/home/update-server /mnt/tmp/ ");
if ( $? == -1 )
{
  print "command failed: $!\n";
}
else
{
}
}



sub copyFiles {
    my ($workdir) = shift;

    my($startdir) = &cwd;               #  start Dir.
    chdir($workdir) or die "Unable to enter dir $workdir:$!\n";

    opendir(DIR, ".") or die "Unable to open $workdir:$!\n";
    my @names = readdir(DIR);
    closedir(DIR);

    foreach my $name (@names){
        next if ($name eq ".");
        next if ($name eq "..");

        if (-d $name){                     
            &copyFiles($name);
#             print $name;        
    next;
        }

if (-f $name) {


$workdir =~ s/\/mnt\/tmp//i;
$workdir =~ s/\/etc-update//i;

}
$final= "/tmp/etc-test/$workdir/$name";
#print"/etc/$workdir/$name\n";
print "$final\n";
copy($name, $final )or die "unable to copy file $Workdir/$name\n";
}
#print "startdirectory is $startdir going into it now \n";
    chdir($startdir) or die "Unable to change to dir $startdir:$!\n";
# print "=====$startdir======\n";
}
&mnt;
&copyFiles("/mnt/tmp/etc-update");

Any Ideas?

Thanks

Mr. C. · 10-08-2008, 03:52 AM

You want to give a hint about what happens when it "breaks"? Or should we guess! :-)

knockout_artist · 10-08-2008, 08:22 AM

I guess I figured out what the issue is.

$final = /start/work/file-------> thats what my final destination look like.

But in some cases it need to be this:
$final= /start/wrok/another-dir/file -------> since directory need to be copied have directoris with directories.

start|
|---------Dir1/file1
|---------Dir2/fie2
|---------Dir3/Dir3a/file3a
|----------|_file3

now when I do copy (file-to-be copied, final)

It only go one step deep.

it does
copy(file-to-be-copy, /start/work/file)
So another-dir get neglected in the path hence it don't copy files /one-dir/two-dir/<here>

Mr. C. · 10-08-2008, 11:12 AM

Is this case solved, or you still need help?

knockout_artist · 10-08-2008, 12:45 PM

I did write a code which worked.
Still I am no artist at writing codes. So You can help If you like.

Mr. C. · 10-08-2008, 01:01 PM

The code has some basic logic flaws, some typo-bugs, and in general could be more generalized.

You call:

&mnt

but if the mount fails, you just print a message and continue as if the mount succeeded. This is not good (what's the point of the error check then)?

$Workdir is referenced, but you mean $workdir. Enable

use strict;
use warnings;

to help you find such problems in the future.

You use hard coded values such as mnt\/tmp in your substitution, and also in your mount command. Place such values in variables at the top of your code and use them throughout. Don't hardcode values throughout your code; parametrize and use variables for ease in changes.

Comment your code!

You don't need the &function form. Use parens:

mnt();
copyFiles(...);

Use single quotes instead of double quotes, skipping interpolation when it is not necessary:

".." -> '..'

Finally, you do realize you can do all this with GNU tar, right?

knockout_artist · 10-08-2008, 01:35 PM

Thanks a lot for the tips.
I will keep it in mind.

tar ?? really how ?

Mr. C. · 10-08-2008, 01:46 PM

tar copies a set of files from one location to another. It has various options for including/excluding or pattern replacing source and targets.

Perhaps you can explain exactly which source(s) / target(s) you want, and any exceptions.

The mount of the remote file system can still be in your wrapper script that calls tar.

knockout_artist · 10-08-2008, 02:25 PM

Since we are at it, Why that don't work ?

$ntwrk = "service network restart";
$ssh = "service sshd restart";
$sndml ="service sendmail restart";

@services = qw/$ntwrk, $ssh $sndml/;

foreach $services(@services){
#print "$ntwrk\n";
print "$services";

#system($services);

}
~

chrism01 · 10-08-2008, 08:04 PM

Here's a cleaned-up version:

Code:

use strict;
use warnings;

my $ntwrk = "service network restart";
my $ssh = "service sshd restart";
my $sndml ="service sendmail restart";
my (@service_list, $service);

@service_list = ($ntwrk, $ssh, $sndml);

foreach $service (@service_list)
{
    print "$service \n";
}

Please use code tags when posting. Also, always use

use strict;
use warnings;

at the top of your code

Read & digest:
http://perldoc.perl.org/
http://www.perlmonks.org/?node=Tutorials

PS you can use the -w switch instead of 'use warnings':
#!/usr/bin/perl -w