./menu.txt: line 1: syntax error near unexpected token 'new line'

jhouston2010 · 03-12-2013, 06:38 AM

Hi im a begginer on opensuse, i currently tried to make a menu script and i started by simply sorting the layout it worked once i first completed it but since then when i try to run it i get, ./menu.txt: line 1: syntax error near unexpected token 'new line'
Here is my script
#!/bin/bash
# Menu
while [ answer != "0" ]
do
clear
echo “Main menu”
echo "Select from the following functions"
echo "0 exit"
echo "1. Set File Directory"
echo "2. Text File Management"
read -p " ?" answer
case $answer in
0) break ;;
1) echo "Go up a directory"
echo “Go into a directory”
echo “Set working directory” ;;
2) echo “List (.txt) files”
echo “Create File”
echo “ Delete File” ;;
*) break ;;
esac
echo "press RETURN for menu"
read key
done
exit 0

I dont know how to copy it from opensuse so above was written in word, but that is exactly how i typed it into linux.

millgates · 03-12-2013, 07:09 AM

1) Make sure your script has unix ( \n ) newlines and not, for example windows ( \r\n ) newlines. If your file is in windows format, you can convert it by for example

Code:

sed -i 's/\r$//' menu.txt

2) Don't use text processors (as opposed to text editors) to write scripts. Your script is full of fancy double quotes instead of the standard, correct ascii 0x22.

3) Use [code]...[/code] tags when posting code.

shivaa · 03-12-2013, 07:10 AM

Problm is with while condition (marked in red), because it cannot compare answer string with 0:

Code:

#!/bin/bash 
while [ answer != "0" ] 
do 
......
.........

So do it like:

Code:

#!/bin/bash 
# Menu 
echo “Main menu”
echo "Select from the following functions [0) Exit; 1) Set File Directory; 2) Text File Management]: "; read -p answer
case $answer in 
0) break ;; 
1) echo "Go up a directory" 
echo “Go into a directory”
echo “Set working directory” ;;
2) echo “List (.txt) files”
echo “Create File”
echo “ Delete File” ;;
*) echo "Wrong choice entered. Exiting"
break ;; 
esac 
echo "press RETURN for menu" 
read key 
exit 0

jhouston2010 · 03-12-2013, 07:27 AM

Sorry millgates is there any chance you could explain that in laymans terms to me haha. I am literally a complete begginer i dont know what you mean by \n new lines or \r\n newlines? Shivaa i tried the to code it how you said and it didnt work thanks any way.
Many regards Jhouston2010

millgates · 03-12-2013, 07:52 AM

How did you create the script in the first place? In windows or in linux? With what program?
The problem is, the various OSes use diferent encoding for the end of the line.
In linux, the character with code 0x0A (decimal 10), also known as "LINE FEED" or LF, is used to denote the end of the line.
In windows world, on the other hand, a two byte sequence consisting of an ascii 0x0D (decimal 13) (CARRIAGE RETURN, or "CR"), followed by a LF is used instead. So, when you have a script with windows newlines, and you try to run it in linux, the shell will interpret the LF character as the end of the line, but the stray CR character preceding it will "remain there" and cause a syntax error.

shivaa · 03-12-2013, 08:04 AM

Can you invoke the script with set -xv and post it's output, so we can check if there's any problem:

Code:

#!/bin/bash 
set -xv
# Menu 
echo “Main menu”
echo "Select from the following functions [0) Exit; 1) Set File Directory; 2) Text File Management]: "; read -p answer
case $answer in 
0) break ;; 
1) echo "Go up a directory" 
echo “Go into a directory”
echo “Set working directory” ;;
2) echo “List (.txt) files”
echo “Create File”
echo “ Delete File” ;;
*) echo "Wrong choice entered. Exiting"
break ;; 
esac
echo "press RETURN for menu" 
read key 
exit 0

jhouston2010 · 03-12-2013, 08:04 AM

I created the script in linux.

millgates · 03-12-2013, 08:30 AM

Quote:

Originally Posted by shivaa

Problm is with while condition (marked in red), because it cannot compare answer string with 0:

Why not? While there's obviously a missing '$' in $answer, and therefore the expression in the brackets will always be true, it will not cause a syntax error.

OP: This command should tell you whether the file is in unix format:

Code:

grep -q $'\r' menu.txt && echo windows || echo unix

jhouston2010 · 03-12-2013, 09:16 AM

I typed in what you said and the answer was unix. :/

millgates · 03-12-2013, 09:36 AM

Can you upload the script exactly as it is? There is obviously some invisible problem that is only present in the original file but not in the code you posted, most likely some stray special character. When I copy the code from your original post and fix the double quotes, the code works as expected.

David the H. · 03-12-2013, 01:56 PM

Please use ***[code][/code]*** tags around your code and data, to preserve the original formatting and to improve readability. Do not use quote tags, bolding, colors, "start/end" lines, or other creative techniques.

bash has a useful select built-in designed specifically for making menus like this:

Code:

#!/bin/bash
# Menu

clear
echo “Main menu”
echo "Select from the following functions"

PS3='Enter a number: '
select answer in "Exit" "Set File Directory" "Text File Management"; do

    echo "You chose "answer"

    case $REPLY in

        1) echo "Exiting the menu"
           break
           ;;

        2) echo "Go up a directory"
           echo "Go into a directory"
           echo "Set working directory"
           ;;

        3) echo "List (.txt) files”
           echo "Create File"
           echo "Delete File"
           ;;

        *) echo "Unknown option.  Please choose again."
           continue
           ;;

    esac

done

echo "press RETURN for menu"
read key

exit 0

In addition, I suggest using functions to modularize the code in the options, particularly if you intend to have sub-menus, as you appear to be doing here. Each menu below the first should have its own function.

As has been explained, Dos/Windows and Unix use different character codes for line endings. If your script or data was created in a Windows-based program, then you'll probably have to convert it before you can use it. A Google search will give you tons of options for doing that.

The file command is perhaps the easiest way to tell which format it's in. If the output says "with CRLF line terminators", it's a dos-style file. Also "cat -A" will show you all non-printing characters in caret notation form. dos files will display a "^M" at the end of every line.

Finally, also beware that Word changes the regular quotes into "smart quotes". These will not be accepted by the script as syntax elements. Only ' and " can be used.