[SOLVED] I would like to know what's wrong my scripts.Please help me!

Monalisa Chan · 11-13-2012, 03:32 AM

Student name=
Student admission=
./choice4.sh: line5: [: missing `]'
Exception :YES
Details:
=========================================
In script,
line1 #!/ usr/bin/bash
line2 echo "Student name= "
line3 echo "Student admission= "
line4 password = cat /etc/default/passwd | grep MAXWEEKS
line5 if [$password == "2" ]
line6then
line7 echo "Exception: NO"
line8 echo "Details:"
line9 echo "=========="
line10 cat /etc/default/passwd | grep MAXWEEKS
line11else
line12 echo "Exception :YES"
line13 echo "Details: "
line14 echo "============"
line15 cat /etc/default/passwd
line16 fi

acid_kewpie · 11-13-2012, 03:36 AM

it looks like you've not transcribed that quite right, but "[" is actually a *program* (well, a link to the /bin/test program), you need to ensure that [ and ] have whitespace around them, like any other option / program name.

note... [ is not great. If you're learning bash, use [[ instead, as it's much nicer to use (and is NOT a program, it's actual bash syntax)

dragonix · 11-13-2012, 03:36 AM

Quote:

Originally Posted by Monalisa Chan

Student name=
Student admission=
./choice4.sh: line5: [: missing `]'
Exception :YES
Details:
=========================================
In script,
line1 #!/ usr/bin/bash
line2 echo "Student name= "
line3 echo "Student admission= "
line4 password = cat /etc/default/passwd | grep MAXWEEKS
line5 if [$password == "2" ]
line6then
line7 echo "Exception: NO"
line8 echo "Details:"
line9 echo "=========="
line10 cat /etc/default/passwd | grep MAXWEEKS
line11else
line12 echo "Exception :YES"
line13 echo "Details: "
line14 echo "============"
line15 cat /etc/default/passwd
line16 fi

try using this

Code:

line5 if [[ $password == "2" ]]

So double [[ and a space between the brackets and values

EDIT
See acid_kewpie's post

acid_kewpie · 11-13-2012, 03:37 AM

Quote:

Originally Posted by dragonix

try using this

Code:

line5 if [[ $password == "2" ]]

So double [[ and a space between the brackets and values

well note that [[ will do proper tokenisation of the string, so there's no need for the "'s in there. unlike [

dragonix · 11-13-2012, 03:41 AM

Quote:

Originally Posted by acid_kewpie

well note that [[ will do proper tokenisation of the string, so there's no need for the "'s in there. unlike [

So, if I get it right, you mean it like

Code:

if [[ $password == 2 ]]

acid_kewpie · 11-13-2012, 03:45 AM

Quote:

Originally Posted by dragonix

So, if I get it right, you mean it like

Code:

if [[ $password == 2 ]]

Yeah, as above it's pure bash, so is processed purely within bash itself instead of being passed through to separate binaries as arbitrary command parameters.

Monalisa Chan · 11-13-2012, 03:46 AM

I put double [[ . Now I can fix the error. Thanks a lot =)