[SOLVED] how to make a script...of changing extention

Ajay jones · 03-31-2014, 11:16 PM

i have four files
file1 file2.old file3old file4

i want to change search for file extention if.. theres already .old then no change.. otherwise change the file with .old extention..

so output should be..
file1.old file2.old(remain unchanged bcz already have it) file3old.old file4.old

>> i want to run script like
scriptname dir
putoldext testdir
so it will change the testdir directories files with old ext.

i tried this..
for file in 'ls .1$'
do echo $file | grep \.old$ > /dev/null
if [ $file != 0 ]
then mv $file $file.old
else echo $file
fi
done

plz help

pan64 · 04-01-2014, 01:03 AM

use [code]here comes your script[/code] to keep formatting
please post your script, not only parts, also use set -vx to see what's happening.

Code:

#!/bin/bash
set -xv
for file in 'ls .1$'
  do echo $file | grep \.old$ > /dev/null
  if [ $file != 0 ]
    then mv $file $file.old
  else echo $file
  fi
done

Please try to explain those lines:
what is ls .1$ good for?
and this: echo $file | grep \.old$ > /dev/null
what about this: if [ $file != 0 ] (you ought to use if [ "$file" != 0 ])

grail · 04-01-2014, 01:05 AM

Firstly, please use [code][/code] tags around code and data to make them more readable.

As for your script, I think you are over-thinking a little, although the actual code would need to be a little longer.

Looking at your requirements:

pseudo code:

Code:

loop through directory names passed in as arguments
  test if dir is dir, proceed for true or skip to next if not
  loop over contents of dir
    test found item is a file and does not end in '.old', on true add new '.old' extension

I believe all this can be done in bash with the only external command being mv

nithinsugathan · 04-01-2014, 08:50 AM

If I am not mistaken you can do this with find command

Code:

find /path/to/files -type f ! -name '*.old' -exec mv {} {}.old \;

Ajay jones · 04-01-2014, 08:07 PM

thanks Pan64!! i got it and it works for me..
thank you so much

grail · 04-02-2014, 02:17 AM

hmmm ... pan64 did not provide a solution so I am curious as to what worked for you?

Please post solution so others may learn from you as well

Ajay jones · 04-03-2014, 12:11 AM

haha... grail..

and somehow i done by myself.. but i got way through his script..
but i appreciated whatever he posted so.. ya i did say it works and actually it does..
thanks again.. pan64

grail · 04-03-2014, 03:00 AM

So again, are you going to post the working version so people may learn as you did?