[SOLVED] Another quick bash question :)

jonnybinthemix · 06-16-2014, 02:10 PM

Ahh I see... so since we are telling it to do this to all files within the directory, we don't actually need to find the files every time.

That makes perfect sense!! I like it...

I'm going to play around with this idea, I like it a lot..

Thanks so much for your help.

ntubski · 06-16-2014, 03:27 PM

Quote:

Originally Posted by jonnybinthemix

so since we are telling it to do this to all files within the directory, we don't actually need to find the files every time.

The benefit of the find command is that is searches through the subdirectories recursively, since everything is in one directory we can use globbing instead which is simpler but less powerful.

We can avoid refinding the files regardless of where they are.

jonnybinthemix · 06-17-2014, 04:13 AM

I am trying this out, and it's looking like it could work fine.. but I am struggling to actually get it going. It's moaning;

usage: gpg [options] --encrypt [filename]
local: *170614*.csv.pgp: No such file or directory
-eFTP TRANSFER FAILED. \n\n *170614*.csv.pgp failed to upload to server

Code:

#!/bin/bash

HOST=X.X.X.X
USER=user
PASS=pass
FTPLOG=/tmp/ftplogfile

cd /sitsimp

for i in "*$(date +%d%m%y)*.csv"; do
        gpg -r server@bathspa.ac.uk -e "$i" -o "$i.pgp";

        ftp -inv $HOST <<! > $FTPLOG
                user $USER xxxx
                binary
                put $i.pgp
        bye
!
        if fgrep "226 Transfer Complete" $FTPLOG; then
                echo -e "FTP TRANSFER SUCCESS. \n\n $i.pgp has uploaded to server"
        else
                echo -e"FTP TRANSFER FAILED. \n\n $i.pgp failed to upload to server"
        fi
done

jonnybinthemix · 06-17-2014, 04:16 AM

I have tried moving the "'s around the filename section but I can't seem to make any difference with it.

I've tried
"*$(date +%d%m%y)*.csv" & *$"(date +%d%m%y)"*.csv

pan64 · 06-17-2014, 04:19 AM

just insert set -xv at the beginning of the script and you will see what's happening

jonnybinthemix · 06-17-2014, 04:52 AM

Ah thanks, that's a neat little trick

I can see that it's definitely something to do with the filename... does the for loop not like the * wildcard?

Code:

++ date +%d%m%y
+ for i in '"$(date +%d%m%y)*.csv"'
+ gpg -r server@bathspa.ac.uk -e '170614*.csv' -o '170614*.csv.pgp'
usage: gpg [options] --encrypt [filename]

So it's looking for a file that literally is todays date, not that has todays date in the filename...

pan64 · 06-17-2014, 04:55 AM

probably:

Code:

D=$(date +%d%m%y)
for i in $D*.csv
...

but it will fail if there was no such file at all

pan64 · 06-17-2014, 04:55 AM

probably:

Code:

D=$(date +%d%m%y)
for i in $D*.csv
...

but it will fail if there was no such file at all

jonnybinthemix · 06-17-2014, 05:04 AM

I've whittled it down to the command..

I adjusted the file thing and it's now finding the correct file.

When I manually run the following command, it does not work:

Code:

gpg -r server@bathspa.ac.uk -e 170614094401.csv -o 170614094401.csv.pgp

I think it doesn't like being told the name of the output file?

jonnybinthemix · 06-17-2014, 05:39 AM

playing around some more has got me passed this hurdle.. just an issue with FTP now which I'll continue to pick away at.

This seemed to work:

Code:

for i in $(date +%d%m%y)*.csv; do
        gpg -r server@bathspa.ac.uk -o "$i.pgp" -e "$i";

ntubski · 06-17-2014, 12:19 PM

Note the placement of the quotes. If the * is inside the quotes it doesn't get glob expanded.

Quote:

Originally Posted by ntubski

Code:

for i in *"$(date +%d%m%y)"*.csv; do

Quote:

Originally Posted by jonnybinthemix

Code:

for i in "*$(date +%d%m%y)*.csv"; do

You can omit the quotes entirely, which shouldn't make a difference as long as the date format you're using doesn't have any spaces in it.

jonnybinthemix · 06-17-2014, 01:53 PM

Hey,

In fact that's what I ended up doing... omitting the quotes all together, which worked fine. I've now stumbled across another issue relating to the same script which I've started a new thread for, to make searching easier for others