[SOLVED] Patch proposed for kernel 4.9 of the debian 9.1.0 by Amos Tibaldi, the short version

anon007 · 07-28-2017, 06:59 AM

Code:

tibaldi@localhost:/usr/src/linux-source-4.9$ grep -r "send\ auth\ t" *
Binary file net/mac80211/mlme.o matches
Binary file net/mac80211/mac80211.o matches
net/mac80211/mlme.c:	sdata_info(sdata, "send auth to %pM (try %d/%d)\n",
Binary file net/mac80211/mac80211.ko matches
tibaldi@localhost:/usr/src/linux-source-4.9$ 
static int ieee80211_auth(struct ieee80211_sub_if_data *sdata)
{
	struct ieee80211_local *local = sdata->local;
	struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
	struct ieee80211_mgd_auth_data *auth_data = ifmgd->auth_data;
	u32 tx_flags = 0;
	u16 trans = 1;
	u16 status = 0;
	sdata_assert_lock(sdata);
	if (WARN_ON_ONCE(!auth_data))
		return -EINVAL;
	auth_data->tries++;
	if (auth_data->tries > IEEE80211_AUTH_MAX_TRIES) {
		sdata_info(sdata, "authentication with %pM timed out\n",
			   auth_data->bss->bssid);
		cfg80211_unlink_bss(local->hw.wiphy, auth_data->bss);
		return -ETIMEDOUT;
	}
	drv_mgd_prepare_tx(local, sdata);
	sdata_info(sdata, "send auth to %pM (try %d/%d)\n",
		   auth_data->bss->bssid, auth_data->tries,
		   IEEE80211_AUTH_MAX_TRIES);
	auth_data->expected_transaction = 2;
	if (auth_data->algorithm == WLAN_AUTH_SAE) {
		trans = auth_data->sae_trans;
		status = auth_data->sae_status;
		auth_data->expected_transaction = trans;
	}
	if (ieee80211_hw_check(&local->hw, REPORTS_TX_ACK_STATUS))
		tx_flags = IEEE80211_TX_CTL_REQ_TX_STATUS |
			   (IEEE80211_TX_INTFL_MLME_CONN_TX && (!(IEEE80211_TX_CTL_REQ_TX_STATUS)));
	ieee80211_send_auth(sdata, trans, auth_data->algorithm, status,
			    auth_data->data, auth_data->data_len,
			    auth_data->bss->bssid,
			    auth_data->bss->bssid, NULL, 0, 0,
			    tx_flags);
	if (tx_flags == 0) {
		auth_data->timeout = jiffies + IEEE80211_AUTH_TIMEOUT;
		auth_data->timeout_started = true;
		run_again(sdata, auth_data->timeout);
	} else {
		auth_data->timeout =
			round_jiffies_up(jiffies + IEEE80211_AUTH_TIMEOUT_LONG);
		auth_data->timeout_started = true;
		run_again(sdata, auth_data->timeout);
	}
	return 0;
}
static int ieee80211_do_assoc(struct ieee80211_sub_if_data *sdata)
{
tibaldi@localhost:~$ cd /usr/src/linux-source-4.9/
tibaldi@localhost:/usr/src/linux-source-4.9$ make -j 9
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/package.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/bounds.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CC [M]  net/mac80211/mlme.o
  LD [M]  net/mac80211/mac80211.o
  Building modules, stage 2.
  DATAREL arch/x86/boot/compressed/vmlinux
Kernel: arch/x86/boot/bzImage is ready  (#1)
  MODPOST 3381 modules
  LD [M]  net/mac80211/mac80211.ko
tibaldi@localhost:/usr/src/linux-source-4.9$
Amos Tibaldi ( tibaldi.amos@gmail.com ), born in Italy; please check the correctness of the patch before applying it. Thanks!

Ser Olmy · 07-28-2017, 04:59 PM

A few points:

As I mentioned in my reply to your other post, Linus Torvalds and the other kernel devs won't see this unless you post it to the Linux kernel mailing list.
Code tags look like this: [code] [/code]
There's no point in putting your entire post inside [code] tags; only the actual code should be formatted as such.
What you've posted is not a patch, but a piece of code intermingled with some other information. It's very hard to read, and it's not even clear which file you've modified.

Use the diff tool to generate a universal patch by comparing the old and new versions of the file in question, then post that to the LKML. That's the official (and only!) way to get a patch for the Linux kernel approved and pushed.

anon007 · 08-02-2017, 04:55 PM

Thanks; by the way, my CODE tags were for the formatting in the HTML5 W3C standard.
Code:

[removed]

Quote:

Originally Posted by Ser Olmy

A few points:

As I mentioned in my reply to your other post, Linus Torvalds and the other kernel devs won't see this unless you post it to the Linux kernel mailing list.
Code tags look like this: [code] [/code]
There's no point in putting your entire post inside [code] tags; only the actual code should be formatted as such.
What you've posted is not a patch, but a piece of code intermingled with some other information. It's very hard to read, and it's not even clear which file you've modified.

Use the diff tool to generate a universal patch by comparing the old and new versions of the file in question, then post that to the LKML. That's the official (and only!) way to get a patch for the Linux kernel approved and pushed.

jeremy · 08-03-2017, 08:36 AM

@AmosTibaldi, that kind of language isn't acceptable here.

--jeremy

anon007 · 08-03-2017, 01:23 PM

Yes, you are right, Jeremy. Forgive me. Thanks.

Quote:

Originally Posted by jeremy

@AmosTibaldi, that kind of language isn't acceptable here.

--jeremy