Whats wrong with my dialing script?

pen^2 · 09-02-2004, 02:41 AM

I have a fresh install of Fedora Core 2 (default desktop) and I have been unable to use my dial up connection with it. I have made posts about it in the past, [url]here is the main one.

I've given up trying to get wvdial to work, but I found this dialing script in another post here:

Code:

~# cat ppp-test.sh
#!/bin/sh
#
# The info behind the equal signal must not contain spaces
#
REMOTEHOST=myisp.com.au # your ISP domain name
TELEPHONE=123456789    # your ISP phone number
ACCOUNT=myname   # your account name on your ISP
PASSWORD=mypassword # your password
DEVICE=/dev/ttyS1 # modem port
SPEED=115200 # modem speed
#
[ ! -d /etc/ppp ] && mkdir /etc/ppp
SECRET=`echo \"$ACCOUNT\"       \"$REMOTEHOST\" \"$PASSWORD\"`
if [ ! -e /etc/ppp/pap-secrets ] || [ `egrep -c "$SECRET" /etc/ppp/pap-secrets` -eq 0 ]
then
  echo "$SECRET" >>/etc/ppp/pap-secrets
fi
if [ ! -e /etc/ppp/chap-secrets ] || [ `egrep -c "$SECRET" /etc/ppp/chap-secrets` -eq 0 ]
then
  echo "$SECRET" >>/etc/ppp/chap-secrets
fi
exec /usr/sbin/pppd \
        lock \
        modem \
        crtscts \
        $DEVICE \
        115200 \
        kdebug 0 \
        noauth \
        noipdefault \
        defaultroute \
        ipcp-accept-local \
        ipcp-accept-remote \
        usepeerdns \
        name $ACCOUNT \
        remotename $REMOTEHOST \
        connect "       \
        /usr/sbin/chat -v       \
                TIMEOUT         3       \
                ABORT   '\nBUSY\r'      \
                ABORT   '\nNO ANSWER\r' \
                ABORT   '\nRINGING\r\n\r\nRINGING\r'    \
                ''      '\rAT'  \
                'OK-+++\c-OK'   'AT&F1M1L0X4'   \
                TIMEOUT         45      \
                OK      ATX4    \
                OK      ATD${TIPDISC}${TELEPHONE}       \
                CONNECT         '

I saved it as “dialup” made it executable, and ran it as root but get the following errors:

./dialup: line 1: ~#: command not found
./dialup: line 50: syntax error: unexpected end of file

Strange since it's only 49 lines long, but it keeps adding a blank line anyway. Can somebody tell me how I can resolve these errors and perhaps finally get online with Fedora?

Thanks in advance.

murugesan · 09-02-2004, 03:25 AM

Remove the '~' symbol at the beginning of the script.

JZL240I-U · 09-02-2004, 03:47 AM

Quote:

Originally posted by pen^2
...
~# cat ppp-test.sh
...

Looks like you left this

Code:

~# cat ppp-test.sh

in your file which will obviously produce an error
(Also, first line must be the shell declaration, i.e. your #!/bin/sh).

Quote:

Originally posted by pen^2
....
/dialup: line 50: syntax error: unexpected end of file
...

What about an exit statement like

Code:

exit 0

?

pen^2 · 09-03-2004, 02:48 AM

Thanks for the help so far, but its only half solved. The first error is gone, but even with the exit statement I get the "./dialup: line 50: syntax error: unexpected end of file" error, any more ideas?

Thanks again.

JZL240I-U · 09-03-2004, 02:52 AM

Please indicate line 50.

Did you delete one line? If so, why is the error still at line 50 and not at 49?

pen^2 · 09-03-2004, 03:46 AM

I didn't delete any lines, all I did was add the line "exit 0" to the end. The reason it says line 50 is because I copied the error from my post rather than the terminal, just got lazy. It's the last line anyway.

Thanks.

JZL240I-U · 09-03-2004, 04:18 AM

Um, your last line holds only one '
i.e.

Code:

CONNECT         '

I don't know the syntax, but that seems unusual?!?
What about deleting it or using two of them...

pen^2 · 09-03-2004, 05:29 AM

I apologise for the confusion so far. This is what the script currently looks like.

Code:

#!/bin/sh
# cat ppp-test.sh
#
# The info behind the equal signal must not contain spaces
#
REMOTEHOST=domain.com.au # your ISP domain name
TELEPHONE=0123456789    # your ISP phone number
ACCOUNT=myname   # your account name on your ISP
PASSWORD=mypassword # your password
DEVICE=/dev/ttyS1 # modem port
SPEED=115200 # modem speed
#
[ ! -d /etc/ppp ] && mkdir /etc/ppp
SECRET=`echo \"$ACCOUNT\"       \"$REMOTEHOST\" \"$PASSWORD\"`
if [ ! -e /etc/ppp/pap-secrets ] || [ `egrep -c "$SECRET" /etc/ppp/pap-secrets` -eq 0 ]
then
  echo "$SECRET" >>/etc/ppp/pap-secrets
fi
if [ ! -e /etc/ppp/chap-secrets ] || [ `egrep -c "$SECRET" /etc/ppp/chap-secrets` -eq 0 ]
then
  echo "$SECRET" >>/etc/ppp/chap-secrets
fi
exec /usr/sbin/pppd \
        lock \
        modem \
        crtscts \
        $DEVICE \
        115200 \
        kdebug 0 \
        noauth \
        noipdefault \
        defaultroute \
        ipcp-accept-local \
        ipcp-accept-remote \
        usepeerdns \
        name $ACCOUNT \
        remotename $REMOTEHOST \
        connect "       \
        /usr/sbin/chat -v       \
                TIMEOUT         3       \
                ABORT   '\nBUSY\r'      \
                ABORT   '\nNO ANSWER\r' \
                ABORT   '\nRINGING\r\n\r\nRINGING\r'    \
                ''      '\rAT'  \
                'OK-+++\c-OK'   'AT&F1M1L0X4'   \
                TIMEOUT         45      \
                OK      ATX4    \
                OK      ATD${TIPDISC}${TELEPHONE}       \
                CONNECT         ''"
exit 0

Then when I run it I get the error:

line 51: syntax error: unexpected end of file.

As before the script is only 50 lines long, but as soon as I run it an extra blank line is added to the end.

Thanks again for the help thus far.

JZL240I-U · 09-03-2004, 06:08 AM

What editor did you use? Reason for my question is Microsoft, of course

.

*nix needs only one of <CR/LF> (Carriage Return / Line Feed of the typewriters of olden), µsoft both. Find out what your editor inserts when you hit <Enter> and change it if necessary or use another editor -- maybe this is causing your problem...

pen^2 · 09-03-2004, 07:17 AM

The only editors I have used are gedit and vi. Neither is set to insert more than one carriage return so I don't think thats the problem.

I really appreciate all the help, although its beginning to look hopeless.

JZL240I-U · 09-03-2004, 08:14 AM

I don't know your system. So.

Code:

#!/bin/sh

means "This is a script -- for any shell you might want to use". Just to be sure try

Code:

#!/bin/bash

This is not portable but might clear the problem. (Google asked for "linux bash syntax error: unexpected end of file" comes up with mostly syntax errors concerning the if statement. You might want to experiment here further...).

Umm, that's assuming you use bash...

hari_s_82 · 09-16-2004, 02:07 AM

Hi,
It seems like you have missed the semi colon(;) after the if statement. Just try adding the semi-colon and see whether it works. Usually i have encountered these kind of errors when i have screwed up something with the if statement. Just try this one ok.

Three common errors can occur when using the if statement:

• Omitting the semicolon (;) before the then statement in the single line form.
• Using else if or elsif instead of elif.
• Omitting the then statement when an elif statement is used.
• Writing if instead of fi at the end of an if statement.

JZL240I-U · 09-16-2004, 02:22 AM

That's a very good list. Thanks for posting it

.

hari_s_82 · 09-16-2004, 02:34 AM

Thanks, hope it works