Using variable array in shell script

massy · 01-06-2014, 07:35 AM

I want to increase my variable array an display it in a for loop:
this is my code, but it doesn't work
count[$i]='expr ${count[i]}+1'
echo ${count[$i]}

druuna · 01-06-2014, 07:55 AM

Not sure why you need an array for this but have a look at this:

Code:

#!/bin/bash

for i in {1..5}
do
  count[$i]=$i       # fill count[X] with X
  (( count[$i]++ ))  # add one to count[X]
done

# show array content
echo ${count[1]}
echo ${count[2]}
echo ${count[3]}
echo ${count[4]}
echo ${count[5]}

Example run:

Code:

$ ./foo.sh
2
3
4
5
6

massy · 01-06-2014, 10:59 PM

Quote:

Originally Posted by druuna

Not sure why you need an array for this but have a look at this:

Code:

#!/bin/bash

for i in {1..5}
do
  count[$i]=$i       # fill count[X] with X
  (( count[$i]++ ))  # add one to count[X]
done

# show array content
echo ${count[1]}
echo ${count[2]}
echo ${count[3]}
echo ${count[4]}
echo ${count[5]}

Example run:

Code:

$ ./foo.sh
2
3
4
5
6

Thank you, I have a condition to do it.
for i in {1..15}
do
cut -d';' --fields="$i" tehrasht.txt>m.txt
while read LINE
do
if [ $LINE == '1' ];then
((count["$i"]++))
fi
done < m.txt
echo ${count[$i]}
count[$i]=0
done

Now, It show the output, but before it,the error is shown:
./obu.txt: line 6: [: too many arguments

massy · 01-06-2014, 11:09 PM

Quote:

Originally Posted by massy

Thank you, I have a condition to do it.

for i in {1..15}
do
cut -d';' --fields="$i" tehrasht.txt>m.txt
while read LINE
do
if [ $LINE == '1' ];then
((count["$i"]++))
fi
done < m.txt
echo ${count[$i]}
count[$i]=0
done

Now, It show the output, but before it,the error is shown:
./obu.txt: line 6: [: too many arguments

druuna · 01-07-2014, 03:21 AM

Quote:

Originally Posted by massy

for i in {1..15}
do
cut -d';' --fields="$i" tehrasht.txt>m.txt
while read LINE
do
if [ $LINE == '1' ];then
((count["$i"]++))
fi
done < m.txt
echo ${count[$i]}
count[$i]=0
done

Now, It show the output, but before it,the error is shown:
./obu.txt: line 6: [: too many arguments

You need to put variables between quotes otherwise you might get unexpected results.

Have a look at this:

Code:

#!/bin/bash

for i in {1..15}
do
  cut -d';' --fields="$i" tehrasht.txt > m.txt
  while read LINE
  do
    if [ "$LINE" == "1" ]  # $LINE needs to be quoted.
    then
      (( count["$i"]++ ))
    fi
  done < m.txt
  echo ${count[$i]}
  count[$i]=0
done

I'm assuming (don't know what tehrasht.txt holds) that LINE contains a value that has spaces or something like it in it.

BTW: It doers look like you are trying to do this the hard way, but without knowing what the content of tehrasht.txt is and what you are attempting to do I cannot give you any hints.

chrism01 · 01-09-2014, 04:36 AM

One way to check the program in detail

Code:

#!/bin/bash
set -xv

<rest of your code here>

The set cmd prints the before & after versions of the code and var contents