Dark on light is easier when it's light and light on dark is better in the dark. I like the look of green on black for a console, though. It's very sci-fi
. But for X I use dark on light, seeing as that's the standard for web pages and most apps. I'm too lazy to edit themes.